diff options
| author | Matthew Heon <matthew.heon@pm.me> | 2020-06-16 17:32:01 -0400 |
|---|---|---|
| committer | Matthew Heon <matthew.heon@pm.me> | 2020-06-16 17:32:01 -0400 |
| commit | c51c593ff630719d9d897319a7afabf412580d68 (patch) | |
| tree | e1f8340019cf1e43581a73c6885fce4d1c5aaaa8 /cmd/podman | |
| parent | d6965da26d194c7edfef65985d4a2c7b564a3fca (diff) | |
| download | podman-c51c593ff630719d9d897319a7afabf412580d68.tar.gz podman-c51c593ff630719d9d897319a7afabf412580d68.tar.bz2 podman-c51c593ff630719d9d897319a7afabf412580d68.zip | |
Re-add resource limit warnings to Specgen
These were part of Podman v1.9, but were lost in the transition
to using Specgen to create containers. Most resource limits are
checked via the sysinfo package to ensure they are safe to use
(the cgroup is mounted, kernel support is present, etc) and
removed if not safe. Further, bounds checks are performed to
ensure that values are valid.
Ensure these warnings are printed client-side when they occur.
This part is a little bit gross, as it happens in pkg/infra and
not cmd/podman, which is largely down to how we implemented
`podman run` - all the work is done in pkg/infra and it returns
only once the container has exited, and we need warnings to print
*before* the container runs. The solution here, while inelegant,
avoid the need to extensively refactor our handling of run.
Should fix blkio-limit warnings that were identified by the FCOS
test suite.
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Diffstat (limited to 'cmd/podman')
| -rw-r--r-- | cmd/podman/common/specgen.go | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/cmd/podman/common/specgen.go b/cmd/podman/common/specgen.go index 0b44ef544..2a070710a 100644 --- a/cmd/podman/common/specgen.go +++ b/cmd/podman/common/specgen.go @@ -635,8 +635,6 @@ func FillOutSpecGen(s *specgen.SpecGenerator, c *ContainerCLIOpts, args []string s.Remove = c.Rm s.StopTimeout = &c.StopTimeout - // TODO where should we do this? - // func verifyContainerResources(config *cc.CreateConfig, update bool) ([]string, error) { return nil } |