diff options
author | Paul Holzinger <pholzing@redhat.com> | 2022-06-13 16:08:46 +0200 |
---|---|---|
committer | Paul Holzinger <pholzing@redhat.com> | 2022-06-14 16:29:42 +0200 |
commit | 41528739cef3d2b61e9b7437f6c557e60dbb79c0 (patch) | |
tree | 6fec977dbeb99f71e439d79333ea74114881e31f /cmd/rootlessport | |
parent | 78ecdad5f8f16dbb6146f2741a3d7ead1ce837bc (diff) | |
download | podman-41528739cef3d2b61e9b7437f6c557e60dbb79c0.tar.gz podman-41528739cef3d2b61e9b7437f6c557e60dbb79c0.tar.bz2 podman-41528739cef3d2b61e9b7437f6c557e60dbb79c0.zip |
golangci-lint: enable nolintlint
The nolintlint linter does not deny the use of `//nolint`
Instead it allows us to enforce a common nolint style:
- force that a linter name must be specified
- do not add a space between `//` and `nolint`
- make sure nolint is only used when there is actually a problem
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Diffstat (limited to 'cmd/rootlessport')
-rw-r--r-- | cmd/rootlessport/main.go | 4 | ||||
-rw-r--r-- | cmd/rootlessport/wsl_test.go | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/cmd/rootlessport/main.go b/cmd/rootlessport/main.go index 5bd35a985..f01b9e4a6 100644 --- a/cmd/rootlessport/main.go +++ b/cmd/rootlessport/main.go @@ -226,8 +226,8 @@ outer: // https://github.com/containers/podman/issues/11248 // Copy /dev/null to stdout and stderr to prevent SIGPIPE errors if f, err := os.OpenFile("/dev/null", os.O_WRONLY, 0755); err == nil { - unix.Dup2(int(f.Fd()), 1) // nolint:errcheck - unix.Dup2(int(f.Fd()), 2) // nolint:errcheck + unix.Dup2(int(f.Fd()), 1) //nolint:errcheck + unix.Dup2(int(f.Fd()), 2) //nolint:errcheck f.Close() } // write and close ReadyFD (convention is same as slirp4netns --ready-fd) diff --git a/cmd/rootlessport/wsl_test.go b/cmd/rootlessport/wsl_test.go index 83d7e3717..2c95251cd 100644 --- a/cmd/rootlessport/wsl_test.go +++ b/cmd/rootlessport/wsl_test.go @@ -20,7 +20,7 @@ type SpecData struct { } func TestDualStackSplit(t *testing.T) { - //nolint + //nolint:revive,stylecheck const ( IP4_ALL = "0.0.0.0" IP4__LO = "127.0.0.1" |