diff options
| author | Charlie Doern <cdoern@redhat.com> | 2022-07-25 10:21:14 -0400 |
|---|---|---|
| committer | Charlie Doern <cdoern@redhat.com> | 2022-07-25 13:11:06 -0400 |
| commit | 27679d80b897b80c10553db0e2048a19ca17737d (patch) | |
| tree | 5346804c8d07150eec7c67e14ceba1e2186830d2 /cmd | |
| parent | da1f47921685f40f1b26405278cbf9cb2d06fe09 (diff) | |
| download | podman-27679d80b897b80c10553db0e2048a19ca17737d.tar.gz podman-27679d80b897b80c10553db0e2048a19ca17737d.tar.bz2 podman-27679d80b897b80c10553db0e2048a19ca17737d.zip | |
pod create --share none should not create infra
for podman pod create, when we are not sharing any namespaces there is no point for the infra container.
This is especially true since resources have also been decoupled from the container recently.
handle this on the cmd level so that we can still create infra if set explicitly
resolves #15048
Signed-off-by: Charlie Doern <cdoern@redhat.com>
Diffstat (limited to 'cmd')
| -rw-r--r-- | cmd/podman/pods/create.go | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/cmd/podman/pods/create.go b/cmd/podman/pods/create.go index aea8a7229..4f1f66ad6 100644 --- a/cmd/podman/pods/create.go +++ b/cmd/podman/pods/create.go @@ -134,6 +134,12 @@ func create(cmd *cobra.Command, args []string) error { imageName = infraImage } img := imageName + + if !cmd.Flag("infra").Changed && (share == "none" || share == "") { + // we do not want an infra container when not sharing namespaces + createOptions.Infra = false + } + if !createOptions.Infra { if cmd.Flag("no-hosts").Changed { return fmt.Errorf("cannot specify --no-hosts without an infra container") |