diff options
| author | Matthew Heon <matthew.heon@pm.me> | 2020-07-23 11:57:34 -0400 |
|---|---|---|
| committer | Matthew Heon <matthew.heon@pm.me> | 2020-07-31 11:36:51 -0400 |
| commit | a34888de319307b6cc1e8b250fb9ded73aa5b6b8 (patch) | |
| tree | ef39e1ae7c0741f4ebb6bcb661ea5c61ca3bd03a /cmd | |
| parent | b75a79b9818d1f94dd5624b043ae571295c2c6dd (diff) | |
| download | podman-a34888de319307b6cc1e8b250fb9ded73aa5b6b8.tar.gz podman-a34888de319307b6cc1e8b250fb9ded73aa5b6b8.tar.bz2 podman-a34888de319307b6cc1e8b250fb9ded73aa5b6b8.zip | |
The `podman start --attach` command should not print ID
Somewhere in the Podman v2 rewrite, we allowed
`podman start --attach` to print the container ID of the started
container after exiting from the attach session (via detach key
or the container exiting naturally). We should never print the ID
when `--attach` is given, which makes the fix simple - make the
print statement conditional on `--attach` not being present.
Wierdly, this only happened with `--interactive` was given to
`podman start`. I don't know why that is, but this resolves the
issue without having to dig any deeper, so I'm content.
Fixes #7055
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Diffstat (limited to 'cmd')
| -rw-r--r-- | cmd/podman/containers/start.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cmd/podman/containers/start.go b/cmd/podman/containers/start.go index 21f22b986..8f9984421 100644 --- a/cmd/podman/containers/start.go +++ b/cmd/podman/containers/start.go @@ -99,7 +99,7 @@ func start(cmd *cobra.Command, args []string) error { } for _, r := range responses { - if r.Err == nil { + if r.Err == nil && !startOptions.Attach { fmt.Println(r.RawInput) } else { errs = append(errs, r.Err) |