aboutsummaryrefslogtreecommitdiff
path: root/install.md
diff options
context:
space:
mode:
authorMatthew Heon <mheon@redhat.com>2022-06-08 09:27:19 -0400
committerMatthew Heon <mheon@redhat.com>2022-06-14 16:12:10 -0400
commit8e2faa4faf22916af453e3aa9abd747c7197f01a (patch)
tree594e63e92c89ddb6802b241d134dbd4b9cc6a340 /install.md
parent8ed9aaba6dbf7190990ce7ba1b190ea9e96f48e4 (diff)
downloadpodman-8e2faa4faf22916af453e3aa9abd747c7197f01a.tar.gz
podman-8e2faa4faf22916af453e3aa9abd747c7197f01a.tar.bz2
podman-8e2faa4faf22916af453e3aa9abd747c7197f01a.zip
Do not error on signalling a just-stopped container
Previous PR #12394 tried to address this, but made a mistake: containers that have just exited do not move to the Exited state but rather the Stopped state - as such, the code would never have run (there is no way we start `podman kill`, and the container transitions to Exited while we are doing it - that requires holding the container lock, which Kill already does). Fix the code to check Stopped as well (we omit Exited entirely but it's a cheap check and our state logic could change in the future). Also, return an error, instead of exiting cleanly - the Kill failed, after all. ErrCtrStateInvalid is already handled by the sig-proxy logic so there won't be issues. [NO NEW TESTS NEEDED] This fixes a race that I cannot reproduce myself, and I have no idea how we'd repro in CI. Signed-off-by: Matthew Heon <mheon@redhat.com>
Diffstat (limited to 'install.md')
0 files changed, 0 insertions, 0 deletions