diff options
| author | Matthew Heon <matthew.heon@pm.me> | 2019-10-14 10:29:54 -0400 |
|---|---|---|
| committer | Matthew Heon <matthew.heon@pm.me> | 2019-10-14 10:32:15 -0400 |
| commit | 0f6b0e8c9ca3bfa944294a0de98869d732988893 (patch) | |
| tree | eb93b90e8ae7e0cea863e1f3c7ac18b205f58bd8 /libpod/define | |
| parent | a8993bab7861e2181630a022484d3f55f706a460 (diff) | |
| download | podman-0f6b0e8c9ca3bfa944294a0de98869d732988893.tar.gz podman-0f6b0e8c9ca3bfa944294a0de98869d732988893.tar.bz2 podman-0f6b0e8c9ca3bfa944294a0de98869d732988893.zip | |
Ensure volumes can be removed when they fail to unmount
Also, ensure that we don't try to mount them without root - it
appears that it can somehow not error and report that mount was
successful when it clearly did not succeed, which can induce this
case.
We reuse the `--force` flag to indicate that a volume should be
removed even after unmount errors. It seems fairly natural to
expect that --force will remove a volume that is otherwise
presenting problems.
Finally, ignore EINVAL on unmount - if the mount point no longer
exists our job is done.
Fixes: #4247
Fixes: #4248
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Diffstat (limited to 'libpod/define')
| -rw-r--r-- | libpod/define/errors.go | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/libpod/define/errors.go b/libpod/define/errors.go index 5392fbc62..523062866 100644 --- a/libpod/define/errors.go +++ b/libpod/define/errors.go @@ -65,6 +65,10 @@ var ( // CGroup. ErrNoCgroups = errors.New("this container does not have a cgroup") + // ErrRootless indicates that the given command cannot but run without + // root. + ErrRootless = errors.New("operation requires root privileges") + // ErrRuntimeStopped indicates that the runtime has already been shut // down and no further operations can be performed on it ErrRuntimeStopped = errors.New("runtime has already been stopped") |