diff options
| author | Valentin Rothberg <rothberg@redhat.com> | 2021-02-15 11:35:34 +0100 |
|---|---|---|
| committer | Matthew Heon <mheon@redhat.com> | 2021-02-18 10:43:41 -0500 |
| commit | 2f3ae7ce5bbe03db13acfa529b5a396e65de1655 (patch) | |
| tree | 9bac9b7812e5c43cd13cdef3401dd0f25ff4384d /libpod | |
| parent | 8d11461a7a659830619cfcdfa2999f8a65beb79a (diff) | |
| download | podman-2f3ae7ce5bbe03db13acfa529b5a396e65de1655.tar.gz podman-2f3ae7ce5bbe03db13acfa529b5a396e65de1655.tar.bz2 podman-2f3ae7ce5bbe03db13acfa529b5a396e65de1655.zip | |
podman build: pass runtime to buildah
Make sure that Podman's default OCI runtime is passed to Buildah in
`podman build`. In theory, Podman and Buildah should use the same
defaults but the projects move at different speeds and it turns out
we caused a regression in v3.0.
Fixes: #9365
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Diffstat (limited to 'libpod')
| -rw-r--r-- | libpod/runtime_img.go | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/libpod/runtime_img.go b/libpod/runtime_img.go index 2c5442bd2..e6caf2626 100644 --- a/libpod/runtime_img.go +++ b/libpod/runtime_img.go @@ -166,6 +166,11 @@ func (r *Runtime) newImageBuildCompleteEvent(idOrName string) { // Build adds the runtime to the imagebuildah call func (r *Runtime) Build(ctx context.Context, options imagebuildah.BuildOptions, dockerfiles ...string) (string, reference.Canonical, error) { + if options.Runtime == "" { + // Make sure that build containers use the same runtime as Podman (see #9365). + conf := util.DefaultContainerConfig() + options.Runtime = conf.Engine.OCIRuntime + } id, ref, err := imagebuildah.BuildDockerfiles(ctx, r.store, options, dockerfiles...) // Write event for build completion r.newImageBuildCompleteEvent(id) |