diff options
| author | Ashley Cui <acui@redhat.com> | 2021-02-22 15:13:46 -0500 |
|---|---|---|
| committer | Ashley Cui <acui@redhat.com> | 2021-03-02 14:28:16 -0500 |
| commit | b19791c0b60b4f113d80e17a9ca9c7c2074be465 (patch) | |
| tree | d03dd9f18392766d5d68efdd94ef2a1ecca4b725 /libpod | |
| parent | 426178a49991106ffe222f12cc42409ae78dd257 (diff) | |
| download | podman-b19791c0b60b4f113d80e17a9ca9c7c2074be465.tar.gz podman-b19791c0b60b4f113d80e17a9ca9c7c2074be465.tar.bz2 podman-b19791c0b60b4f113d80e17a9ca9c7c2074be465.zip | |
Tidy duplicate log tests
Some log tests were duplicated, and some didn't need to be repeated for
every driver. Also, added some comments
Signed-off-by: Ashley Cui <acui@redhat.com>
Diffstat (limited to 'libpod')
| -rw-r--r-- | libpod/container_log.go | 1 | ||||
| -rw-r--r-- | libpod/container_log_linux.go | 1 |
2 files changed, 1 insertions, 1 deletions
diff --git a/libpod/container_log.go b/libpod/container_log.go index a3b700004..c207df819 100644 --- a/libpod/container_log.go +++ b/libpod/container_log.go @@ -29,7 +29,6 @@ func (c *Container) ReadLog(ctx context.Context, options *logs.LogOptions, logCh case define.NoLogging: return errors.Wrapf(define.ErrNoLogs, "this container is using the 'none' log driver, cannot read logs") case define.JournaldLogging: - // TODO Skip sending logs until journald logs can be read return c.readFromJournal(ctx, options, logChannel) case define.JSONLogging: // TODO provide a separate implementation of this when Conmon diff --git a/libpod/container_log_linux.go b/libpod/container_log_linux.go index 5792633b0..4a541b6e7 100644 --- a/libpod/container_log_linux.go +++ b/libpod/container_log_linux.go @@ -52,6 +52,7 @@ func (c *Container) readFromJournal(ctx context.Context, options *logs.LogOption if time.Now().Before(options.Since) { return nil } + // coreos/go-systemd/sdjournal expects a negative time.Duration for times in the past config.Since = -time.Since(options.Since) } config.Matches = append(config.Matches, journal.Match{ |