diff options
| author | Matthew Heon <mheon@redhat.com> | 2021-03-04 16:22:41 -0500 |
|---|---|---|
| committer | Matthew Heon <mheon@redhat.com> | 2021-03-05 09:19:48 -0500 |
| commit | 5bb8fa30b04e08761df6b412e7ef3c7cc0970650 (patch) | |
| tree | 5e4d7ca9c67fabf1229e7d54b6e85b37e78af7f9 /pkg/bindings/test/pods_test.go | |
| parent | 259bb5f7232432bce103c64cf1e68539ab7012e2 (diff) | |
| download | podman-5bb8fa30b04e08761df6b412e7ef3c7cc0970650.tar.gz podman-5bb8fa30b04e08761df6b412e7ef3c7cc0970650.tar.bz2 podman-5bb8fa30b04e08761df6b412e7ef3c7cc0970650.zip | |
Do not return from c.stop() before re-locking
Unlocking an already unlocked lock is a panic. As such, we have
to make sure that the deferred c.lock.Unlock() in
c.StopWithTimeout() always runs on a locked container. There was
a case in c.stop() where we could return an error after we unlock
the container to stop it, but before we re-lock it - thus
allowing for a double-unlock to occur. Fix the error return to
not happen until after the lock has been re-acquired.
Fixes #9615
Signed-off-by: Matthew Heon <mheon@redhat.com>
Diffstat (limited to 'pkg/bindings/test/pods_test.go')
0 files changed, 0 insertions, 0 deletions