diff options
| author | Jhon Honce <jhonce@redhat.com> | 2021-08-02 14:09:55 -0700 |
|---|---|---|
| committer | Matthew Heon <mheon@redhat.com> | 2021-08-30 13:34:34 -0400 |
| commit | f363b805c59ed4d25d89f08e3a099e5c7028eb2f (patch) | |
| tree | c7143d9a08e039192b330e1a0d78d56a0590aa46 /pkg/domain | |
| parent | d1ea5454939745f98c42c00269fd646a08c5b6ac (diff) | |
| download | podman-f363b805c59ed4d25d89f08e3a099e5c7028eb2f.tar.gz podman-f363b805c59ed4d25d89f08e3a099e5c7028eb2f.tar.bz2 podman-f363b805c59ed4d25d89f08e3a099e5c7028eb2f.zip | |
Fix file descriptor leaks and add test
* Add response.Body.Close() where needed to release HTTP
connections to API server.
* Add tests to ensure no general leaks occur. 100% coverage would be
required to ensure no leaks on any call.
* Update code comments to be godoc correct
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Diffstat (limited to 'pkg/domain')
| -rw-r--r-- | pkg/domain/entities/generate.go | 2 | ||||
| -rw-r--r-- | pkg/domain/infra/tunnel/generate.go | 3 |
2 files changed, 5 insertions, 0 deletions
diff --git a/pkg/domain/entities/generate.go b/pkg/domain/entities/generate.go index 3ec713edf..8a437061f 100644 --- a/pkg/domain/entities/generate.go +++ b/pkg/domain/entities/generate.go @@ -35,6 +35,8 @@ type GenerateKubeOptions struct { } // GenerateKubeReport +// +// FIXME: Podman4.0 should change io.Reader to io.ReaderCloser type GenerateKubeReport struct { // Reader - the io.Reader to reader the generated YAML file. Reader io.Reader diff --git a/pkg/domain/infra/tunnel/generate.go b/pkg/domain/infra/tunnel/generate.go index 0e768b30b..3d3cd52be 100644 --- a/pkg/domain/infra/tunnel/generate.go +++ b/pkg/domain/infra/tunnel/generate.go @@ -16,6 +16,9 @@ func (ic *ContainerEngine) GenerateSystemd(ctx context.Context, nameOrID string, return generate.Systemd(ic.ClientCtx, nameOrID, options) } +// GenerateKube Kubernetes YAML (v1 specification) for nameOrIDs +// +// Note: Caller is responsible for closing returned Reader func (ic *ContainerEngine) GenerateKube(ctx context.Context, nameOrIDs []string, opts entities.GenerateKubeOptions) (*entities.GenerateKubeReport, error) { options := new(generate.KubeOptions).WithService(opts.Service) return generate.Kube(ic.ClientCtx, nameOrIDs, options) |