diff options
author | Brent Baude <bbaude@redhat.com> | 2022-04-27 15:16:25 -0500 |
---|---|---|
committer | Brent Baude <bbaude@redhat.com> | 2022-04-27 15:44:02 -0500 |
commit | 83a75d2a3d6a6dd0661f1f44aff13639412c390b (patch) | |
tree | 530f5907adac30a42e5eac1f584d13d90f994d5e /pkg/machine/e2e/inspect_test.go | |
parent | 60d6cc8e1eb33be2f9822e227a7cadf0dceb5543 (diff) | |
download | podman-83a75d2a3d6a6dd0661f1f44aff13639412c390b.tar.gz podman-83a75d2a3d6a6dd0661f1f44aff13639412c390b.tar.bz2 podman-83a75d2a3d6a6dd0661f1f44aff13639412c390b.zip |
Produce better test error messages
As Ed has pointed out, the form of Expect(session).To(Exit(0)) provides
much better error messages. Let's make Ed happy.
Signed-off-by: Brent Baude <bbaude@redhat.com>
Diffstat (limited to 'pkg/machine/e2e/inspect_test.go')
-rw-r--r-- | pkg/machine/e2e/inspect_test.go | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/pkg/machine/e2e/inspect_test.go b/pkg/machine/e2e/inspect_test.go index 30d810b8f..e282dd21d 100644 --- a/pkg/machine/e2e/inspect_test.go +++ b/pkg/machine/e2e/inspect_test.go @@ -7,6 +7,7 @@ import ( . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" + . "github.com/onsi/gomega/gexec" ) var _ = Describe("podman machine stop", func() { @@ -27,24 +28,24 @@ var _ = Describe("podman machine stop", func() { reallyLongName := "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ" session, err := mb.setName(reallyLongName).setCmd(&i).run() Expect(err).To(BeNil()) - Expect(session.ExitCode()).To(Equal(125)) + Expect(session).To(Exit(125)) }) It("inspect two machines", func() { i := new(initMachine) foo1, err := mb.setName("foo1").setCmd(i.withImagePath(mb.imagePath)).run() Expect(err).To(BeNil()) - Expect(foo1.ExitCode()).To(Equal(0)) + Expect(foo1).To(Exit(0)) ii := new(initMachine) foo2, err := mb.setName("foo2").setCmd(ii.withImagePath(mb.imagePath)).run() Expect(err).To(BeNil()) - Expect(foo2.ExitCode()).To(Equal(0)) + Expect(foo2).To(Exit(0)) inspect := new(inspectMachine) inspectSession, err := mb.setName("foo1").setCmd(inspect).run() Expect(err).To(BeNil()) - Expect(inspectSession.ExitCode()).To(Equal(0)) + Expect(inspectSession).To(Exit(0)) type fakeInfos struct { Status string |