diff options
| author | Ed Santiago <santiago@redhat.com> | 2022-07-25 08:07:43 -0600 |
|---|---|---|
| committer | Ed Santiago <santiago@redhat.com> | 2022-07-25 13:08:35 -0600 |
| commit | 94e0a364a80470036d87fa75cf53e60dc0c35fe3 (patch) | |
| tree | c097025be415fe8a4b1e8994b3e068795205f903 /test/e2e/containers_conf_test.go | |
| parent | b70e2a47887f81af0b32dd6ac362f9c4958f5b7c (diff) | |
| download | podman-94e0a364a80470036d87fa75cf53e60dc0c35fe3.tar.gz podman-94e0a364a80470036d87fa75cf53e60dc0c35fe3.tar.bz2 podman-94e0a364a80470036d87fa75cf53e60dc0c35fe3.zip | |
Semiperiodoc cleanup of obsolete FIXMEs
Some refer to issues that are closed. Remove them.
Some are runc bugs that will never be fixed. Say so, and remove
the FIXME.
One (bps/iops) should probably be fixed. File an issue for it, and
update comment to include the issue# so my find-obsolete-skips script
can track it.
And one (rootless mount with a "kernel bug?" comment) is still
not fixed. Leave the skip, but add a comment documenting the symptom.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'test/e2e/containers_conf_test.go')
| -rw-r--r-- | test/e2e/containers_conf_test.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/e2e/containers_conf_test.go b/test/e2e/containers_conf_test.go index 819efa628..41e78ce0e 100644 --- a/test/e2e/containers_conf_test.go +++ b/test/e2e/containers_conf_test.go @@ -535,7 +535,8 @@ var _ = Describe("Verify podman containers.conf usage", func() { It("podman containers.conf cgroups=disabled", func() { if !strings.Contains(podmanTest.OCIRuntime, "crun") { - Skip("FIXME: requires crun") + // Assume this will never be fixed in runc + Skip("NoCgroups requires crun") } conffile := filepath.Join(podmanTest.TempDir, "container.conf") |