diff options
author | Daniel J Walsh <dwalsh@redhat.com> | 2020-09-28 09:17:27 -0400 |
---|---|---|
committer | Daniel J Walsh <dwalsh@redhat.com> | 2020-09-29 16:01:26 -0400 |
commit | b496802413aecf95b0d2786cb6e13618b388a406 (patch) | |
tree | 1d48d952e8dff642ab5db1edbc9d30a4da4fbef5 /test/e2e/login_logout_test.go | |
parent | 453333a35cc791e9031e5d24e0ac5e76a2b2aa75 (diff) | |
download | podman-b496802413aecf95b0d2786cb6e13618b388a406.tar.gz podman-b496802413aecf95b0d2786cb6e13618b388a406.tar.bz2 podman-b496802413aecf95b0d2786cb6e13618b388a406.zip |
Make all Skips specify a reason
Always use CGROUPV2 rather then reading from system all the time.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Diffstat (limited to 'test/e2e/login_logout_test.go')
-rw-r--r-- | test/e2e/login_logout_test.go | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/test/e2e/login_logout_test.go b/test/e2e/login_logout_test.go index 52357b00a..b1255c00a 100644 --- a/test/e2e/login_logout_test.go +++ b/test/e2e/login_logout_test.go @@ -47,7 +47,7 @@ var _ = Describe("Podman login and logout", func() { se := SystemExec("setenforce", []string{"0"}) se.WaitWithDefaultTimeout() if se.ExitCode() != 0 { - Skip("Can not disable selinux, this may cause problem for reading cert files inside container.") + Skip("Cannot disable selinux, this may cause problem for reading cert files inside container.") } defer SystemExec("setenforce", []string{"1"}) } @@ -87,7 +87,7 @@ var _ = Describe("Podman login and logout", func() { Expect(session.ExitCode()).To(Equal(0)) if !WaitContainerReady(podmanTest, "registry", "listening on", 20, 1) { - Skip("Can not start docker registry.") + Skip("Cannot start docker registry.") } }) @@ -116,8 +116,6 @@ var _ = Describe("Podman login and logout", func() { }) It("podman login and logout without registry parameter", func() { - SkipIfRootless() - registriesConf, err := ioutil.TempFile("", "TestLoginWithoutParameter") Expect(err).To(BeNil()) defer registriesConf.Close() @@ -231,7 +229,7 @@ var _ = Describe("Podman login and logout", func() { Expect(session.ExitCode()).To(Equal(0)) if !WaitContainerReady(podmanTest, "registry1", "listening on", 20, 1) { - Skip("Can not start docker registry.") + Skip("Cannot start docker registry.") } session = podmanTest.Podman([]string{"login", "--username", "podmantest", "--password", "test", server}) |