aboutsummaryrefslogtreecommitdiff
path: root/test/e2e/run_dns_test.go
diff options
context:
space:
mode:
authorJhon Honce <jhonce@redhat.com>2019-10-04 10:09:24 -0700
committerJhon Honce <jhonce@redhat.com>2019-10-16 08:10:07 -0700
commit60d0be17fc55404929ad24d861f318968997458f (patch)
treee6aeecf49dd00a8e1f4a32cb3c0638b041fb0572 /test/e2e/run_dns_test.go
parent7825c5827e039aed6656f5df65de2262591681e6 (diff)
downloadpodman-60d0be17fc55404929ad24d861f318968997458f.tar.gz
podman-60d0be17fc55404929ad24d861f318968997458f.tar.bz2
podman-60d0be17fc55404929ad24d861f318968997458f.zip
Refactor tests when checking for error exit codes
Rather than checking for non-zero, we need to check for >0 to distinguish between timeouts and error exit codes. Signed-off-by: Jhon Honce <jhonce@redhat.com>
Diffstat (limited to 'test/e2e/run_dns_test.go')
-rw-r--r--test/e2e/run_dns_test.go10
1 files changed, 5 insertions, 5 deletions
diff --git a/test/e2e/run_dns_test.go b/test/e2e/run_dns_test.go
index dc0f4a8fb..02b9ff8d1 100644
--- a/test/e2e/run_dns_test.go
+++ b/test/e2e/run_dns_test.go
@@ -51,7 +51,7 @@ var _ = Describe("Podman run dns", func() {
It("podman run add bad dns server", func() {
session := podmanTest.Podman([]string{"run", "--dns=foobar", ALPINE, "ls"})
session.WaitWithDefaultTimeout()
- Expect(session.ExitCode()).To(Not(Equal(0)))
+ Expect(session).To(ExitWithError())
})
It("podman run add dns server", func() {
@@ -71,7 +71,7 @@ var _ = Describe("Podman run dns", func() {
It("podman run add bad host", func() {
session := podmanTest.Podman([]string{"run", "--add-host=foo:1.2", ALPINE, "ls"})
session.WaitWithDefaultTimeout()
- Expect(session.ExitCode()).To(Not(Equal(0)))
+ Expect(session).To(ExitWithError())
})
It("podman run add host", func() {
@@ -105,15 +105,15 @@ var _ = Describe("Podman run dns", func() {
It("podman run mutually excludes --dns* and --network", func() {
session := podmanTest.Podman([]string{"run", "--dns=1.2.3.4", "--network", "container:ALPINE", ALPINE})
session.WaitWithDefaultTimeout()
- Expect(session.ExitCode()).To(Not(Equal(0)))
+ Expect(session).To(ExitWithError())
session = podmanTest.Podman([]string{"run", "--dns-opt=1.2.3.4", "--network", "container:ALPINE", ALPINE})
session.WaitWithDefaultTimeout()
- Expect(session.ExitCode()).To(Not(Equal(0)))
+ Expect(session).To(ExitWithError())
session = podmanTest.Podman([]string{"run", "--dns-search=foobar.com", "--network", "none", ALPINE})
session.WaitWithDefaultTimeout()
- Expect(session.ExitCode()).To(Not(Equal(0)))
+ Expect(session).To(ExitWithError())
session = podmanTest.Podman([]string{"run", "--dns=1.2.3.4", "--network", "host", ALPINE})
session.WaitWithDefaultTimeout()