aboutsummaryrefslogtreecommitdiff
path: root/test/e2e/run_volume_test.go
diff options
context:
space:
mode:
authorEd Santiago <santiago@redhat.com>2020-09-23 08:09:31 -0600
committerEd Santiago <santiago@redhat.com>2020-09-23 08:09:31 -0600
commitb7147afde914aa32d4ab05a271d078be2d236885 (patch)
tree694691bbabf007311607a7d52893ca57caf0677a /test/e2e/run_volume_test.go
parent3059bf8ef0877092c1b924cc1069ac9b3a1ebc2f (diff)
downloadpodman-b7147afde914aa32d4ab05a271d078be2d236885.tar.gz
podman-b7147afde914aa32d4ab05a271d078be2d236885.tar.bz2
podman-b7147afde914aa32d4ab05a271d078be2d236885.zip
e2e tests: SkipIfRemote(): add a reason
Now that Dan has added helpful comments to each SkipIfRemote, let's take the next step and include those messages in the Skip() output so someone viewing test results can easily see if a remote test is skipped for a real reason or for a FIXME. This commit is the result of a simple: perl -pi -e 's;(SkipIfRemote)\(\)(\s+//\s+(.*))?;$1("$3");' *.go in the test/e2e directory, with a few minor (manual) changes in wording. Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'test/e2e/run_volume_test.go')
-rw-r--r--test/e2e/run_volume_test.go6
1 files changed, 3 insertions, 3 deletions
diff --git a/test/e2e/run_volume_test.go b/test/e2e/run_volume_test.go
index 11b22e85f..0e0195c9f 100644
--- a/test/e2e/run_volume_test.go
+++ b/test/e2e/run_volume_test.go
@@ -197,7 +197,7 @@ var _ = Describe("Podman run with volumes", func() {
})
It("podman run with volumes and suid/dev/exec options", func() {
- SkipIfRemote() // podman-remote does not support --volumes
+ SkipIfRemote("podman-remote does not support --volumes")
mountPath := filepath.Join(podmanTest.TempDir, "secrets")
os.Mkdir(mountPath, 0755)
@@ -227,7 +227,7 @@ var _ = Describe("Podman run with volumes", func() {
})
It("podman run with tmpfs named volume mounts and unmounts", func() {
- SkipIfRemote() // podman-remote does not support --volumes this test could be simplified to be tested on Remote.
+ SkipIfRemote("podman-remote does not support --volumes this test could be simplified to be tested on Remote.")
SkipIfRootless()
volName := "testvol"
mkVolume := podmanTest.Podman([]string{"volume", "create", "--opt", "type=tmpfs", "--opt", "device=tmpfs", "--opt", "o=nodev", "testvol"})
@@ -453,7 +453,7 @@ VOLUME /test/`
})
It("podman run with overlay volume flag", func() {
- SkipIfRemote() // Overlay volumes only work locally
+ SkipIfRemote("Overlay volumes only work locally")
if os.Getenv("container") != "" {
Skip("Overlay mounts not supported when running in a container")
}