diff options
| author | Alessandro Rossi <al.rossi87@gmail.com> | 2022-08-27 18:28:24 +0200 |
|---|---|---|
| committer | openshift-cherrypick-robot <> | 2022-08-30 19:25:00 +0000 |
| commit | 3439657f91eccae1e4cec2c3fb291d2c55bbe871 (patch) | |
| tree | ca1e03b09e48148a8b46f9493471b0113f696db5 /test | |
| parent | b401ac2a75f36d1c32551936907b3b1df8ecb070 (diff) | |
| download | podman-3439657f91eccae1e4cec2c3fb291d2c55bbe871.tar.gz podman-3439657f91eccae1e4cec2c3fb291d2c55bbe871.tar.bz2 podman-3439657f91eccae1e4cec2c3fb291d2c55bbe871.zip | |
Fix #15499 already connected network
Compat: Treat already attached networks as a no-op
Applies only to containers in created state. Maintain error in running state.
Co-authored-by: Alessandro Rossi <al.rossi87@gmail.com>
Co-authored-by: Brent Baude <bbaude@redhat.com>
Co-authored-by: Jason T. Greene <jason.greene@redhat.com>
Signed-off-by: Alessandro Rossi <al.rossi87@gmail.com>
Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
Diffstat (limited to 'test')
| -rw-r--r-- | test/e2e/network_connect_disconnect_test.go | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/test/e2e/network_connect_disconnect_test.go b/test/e2e/network_connect_disconnect_test.go index c9ffe6a8d..3bb2d4702 100644 --- a/test/e2e/network_connect_disconnect_test.go +++ b/test/e2e/network_connect_disconnect_test.go @@ -156,7 +156,7 @@ var _ = Describe("Podman network connect and disconnect", func() { Expect(con.ErrorToString()).To(ContainSubstring(`"slirp4netns" is not supported: invalid network mode`)) }) - It("podman connect on a container that already is connected to the network should error", func() { + It("podman connect on a container that already is connected to the network should error after init", func() { netName := "aliasTest" + stringid.GenerateNonCryptoID() session := podmanTest.Podman([]string{"network", "create", netName}) session.WaitWithDefaultTimeout() @@ -176,7 +176,15 @@ var _ = Describe("Podman network connect and disconnect", func() { con := podmanTest.Podman([]string{"network", "connect", netName, "test"}) con.WaitWithDefaultTimeout() - Expect(con).Should(ExitWithError()) + Expect(con).Should(Exit(0)) + + init := podmanTest.Podman([]string{"init", "test"}) + init.WaitWithDefaultTimeout() + Expect(init).Should(Exit(0)) + + con2 := podmanTest.Podman([]string{"network", "connect", netName, "test"}) + con2.WaitWithDefaultTimeout() + Expect(con2).Should(ExitWithError()) }) It("podman network connect", func() { |