diff options
| author | Paul Holzinger <pholzing@redhat.com> | 2022-09-07 14:08:52 +0200 |
|---|---|---|
| committer | Paul Holzinger <pholzing@redhat.com> | 2022-09-13 10:33:13 +0200 |
| commit | 90634d5ee2524b532769959bba9f728b520ed1ac (patch) | |
| tree | f572b392eaa7b49c5ace8ca4df5eb7cfacd47cfd /test | |
| parent | 20eccfc9d025965f99ca118d034b39924c6b8659 (diff) | |
| download | podman-90634d5ee2524b532769959bba9f728b520ed1ac.tar.gz podman-90634d5ee2524b532769959bba9f728b520ed1ac.tar.bz2 podman-90634d5ee2524b532769959bba9f728b520ed1ac.zip | |
podman volume ls: use report.Formatter over Template
Currently the podman command --format output code uses a mix of
report.Formatter and report.Template.
I patched report.Formatter to correctly handle newlines[1]. Since we
cannot fix this with report.Template we have to migrate all users to
report.Formatter. This ensures consistent behavior for all commands.
This change does not change the output, we can add a new test for the
newline bug when the common PR is vendored in.
Also fixa bug since the table format is expected to print headers as
well.
[1] https://github.com/containers/common/pull/1146
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Diffstat (limited to 'test')
| -rw-r--r-- | test/e2e/volume_ls_test.go | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/test/e2e/volume_ls_test.go b/test/e2e/volume_ls_test.go index dcfb13f4e..24ea50b26 100644 --- a/test/e2e/volume_ls_test.go +++ b/test/e2e/volume_ls_test.go @@ -75,7 +75,10 @@ var _ = Describe("Podman volume ls", func() { session.WaitWithDefaultTimeout() Expect(session).Should(Exit(0)) - Expect(session.OutputToStringArray()).To(HaveLen(1), session.OutputToString()) + arr := session.OutputToStringArray() + Expect(arr).To(HaveLen(2)) + Expect(arr[0]).To(ContainSubstring("NAME")) + Expect(arr[1]).To(ContainSubstring("myvol")) }) It("podman ls volume with --filter flag", func() { |