1 files changed, 31 insertions, 30 deletions

diff --git a/pkg/domain/infra/abi/images_list.go b/pkg/domain/infra/abi/images_list.go
index 3b8aabeb7..b0e947991 100644
--- a/pkg/domain/infra/abi/images_list.go
+++ b/pkg/domain/infra/abi/images_list.go
@@ -3,23 +3,25 @@ package abi
 import (
 	"context"
 
-	libpodImage "github.com/containers/podman/v3/libpod/image"
+	"github.com/containers/common/libimage"
 	"github.com/containers/podman/v3/pkg/domain/entities"
 	"github.com/pkg/errors"
 )
 
 func (ir *ImageEngine) List(ctx context.Context, opts entities.ImageListOptions) ([]*entities.ImageSummary, error) {
-	images, err := ir.Libpod.ImageRuntime().GetImagesWithFilters(opts.Filter)
-	if err != nil {
-		return nil, err
+	listImagesOptions := &libimage.ListImagesOptions{
+		Filters: opts.Filter,
 	}
-
 	if !opts.All {
-		filter, err := ir.Libpod.ImageRuntime().IntermediateFilter(ctx, images)
-		if err != nil {
-			return nil, err
-		}
-		images = libpodImage.FilterImages(images, []libpodImage.ResultFilter{filter})
+		// Filter intermediate images unless we want to list *all*.
+		// NOTE: it's a positive filter, so `intermediate=false` means
+		// to display non-intermediate images.
+		listImagesOptions.Filters = append(listImagesOptions.Filters, "intermediate=false")
+	}
+
+	images, err := ir.Libpod.LibimageRuntime().ListImages(ctx, nil, listImagesOptions)
+	if err != nil {
+		return nil, err
 	}
 
 	summaries := []*entities.ImageSummary{}
@@ -30,24 +32,21 @@ func (ir *ImageEngine) List(ctx context.Context, opts entities.ImageListOptions)
 		}
 
 		e := entities.ImageSummary{
-			ID:           img.ID(),
-			ConfigDigest: string(img.ConfigDigest),
-			Created:      img.Created().Unix(),
-			Dangling:     img.Dangling(),
-			Digest:       string(img.Digest()),
-			RepoDigests:  digests,
-			History:      img.NamesHistory(),
-			Names:        img.Names(),
-			ReadOnly:     img.IsReadOnly(),
-			SharedSize:   0,
-			RepoTags:     img.Names(), // may include tags and digests
+			ID: img.ID(),
+			//			ConfigDigest: string(img.ConfigDigest),
+			Created:     img.Created().Unix(),
+			Dangling:    img.IsDangling(),
+			Digest:      string(img.Digest()),
+			RepoDigests: digests,
+			History:     img.NamesHistory(),
+			Names:       img.Names(),
+			ReadOnly:    img.IsReadOnly(),
+			SharedSize:  0,
+			RepoTags:    img.Names(), // may include tags and digests
 		}
 		e.Labels, err = img.Labels(ctx)
 		if err != nil {
-			// Ignore empty manifest lists.
-			if errors.Cause(err) != libpodImage.ErrImageIsBareList {
-				return nil, errors.Wrapf(err, "error retrieving label for image %q: you may need to remove the image to resolve the error", img.ID())
-			}
+			return nil, errors.Wrapf(err, "error retrieving label for image %q: you may need to remove the image to resolve the error", img.ID())
 		}
 
 		ctnrs, err := img.Containers()
@@ -56,20 +55,22 @@ func (ir *ImageEngine) List(ctx context.Context, opts entities.ImageListOptions)
 		}
 		e.Containers = len(ctnrs)
 
-		sz, err := img.Size(ctx)
+		sz, err := img.Size()
 		if err != nil {
 			return nil, errors.Wrapf(err, "error retrieving size of image %q: you may need to remove the image to resolve the error", img.ID())
 		}
-		e.Size = int64(*sz)
+		e.Size = sz
 		// This is good enough for now, but has to be
 		// replaced later with correct calculation logic
-		e.VirtualSize = int64(*sz)
+		e.VirtualSize = sz
 
-		parent, err := img.ParentID(ctx)
+		parent, err := img.Parent(ctx)
 		if err != nil {
 			return nil, errors.Wrapf(err, "error retrieving parent of image %q: you may need to remove the image to resolve the error", img.ID())
 		}
-		e.ParentId = parent
+		if parent != nil {
+			e.ParentId = parent.ID()
+		}
 
 		summaries = append(summaries, &e)
 	}