aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Proof of concept: nightly dependency treadmillEd Santiago2022-09-30
| | | | | | | | | | | | | | As discussed in f2f: this is the cleanest, simplest mechanism I can think of to auto-test the Big Three dependencies: simply run go mod edit immediately after git checkout, then run the entire CI test suite. This differs significantly from the buildah treadmill, in that buildah is almost impossible to re-vendor without manual intervention. (In practice, so are these, but let's dream of a world in which this will run and pass every night). (I want a pony too). Signed-off-by: Ed Santiago <santiago@redhat.com>
* Merge pull request #16005 from sstosh/fix-typoOpenShift Merge Robot2022-09-30
|\ | | | | Fix typo about e2e tests name
| * Fix typo about e2e tests nameToshiki Sonoda2022-09-30
| | | | | | | | | | | | | | | | | | | | * podman stop --all -> podman kill --all * podman pause --filter -> podman restart --filter [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
* | Merge pull request #15868 from rst0git/podman-run-checkpoint-imgOpenShift Merge Robot2022-09-30
|\ \ | |/ |/| cmd/podman: add support for checkpoint images
| * Add test for podman run with checkpoint imageRadostin Stoyanov2022-09-29
| | | | | | | | | | | | | | | | | | The `podman run` command has been extended with support for checkpoint images. A checkpoint image contains image files generated by criu that allow to restore the runtime state of containerized applications. This patch adds a test case for this functionality. Signed-off-by: Radostin Stoyanov <radostin@redhat.com>
| * cmd/podman: add support for checkpoint imagesRadostin Stoyanov2022-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch extends the podman run command with support for checkpoint images. When `podman run` is invoked with an image that contains a checkpoint, it would restore the container from that checkpoint. Example: podman run -d --name looper busybox /bin/sh -c \ 'i=0; while true; do echo $i; i=$(expr $i + 1); sleep 1; done' podman container checkpoint --create-image checkpoint-image-1 looper podman run checkpoint-image-1 Signed-off-by: Radostin Stoyanov <radostin@redhat.com>
| * restore: make IsCheckpointImage reusableRadostin Stoyanov2022-09-29
| | | | | | | | | | | | | | | | | | | | Podman allows to store a container checkpoints as an images. This patch makes the check that is used to recognise such checkpoint images reusable by moving it in utils. This functionality will be reused in a subsequent patch to extend the `podman run` command with support for checkpoint images. Signed-off-by: Radostin Stoyanov <radostin@redhat.com>
* | Merge pull request #15909 from cdoern/restoreOpenShift Merge Robot2022-09-29
|\ \ | | | | | | fix restore API endpoint
| * | fix restore API endpointcdoern2022-09-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | restore endpoint was totally ignoring --pod, it was missing from the schema and from query handling on the api handlers side. add support for it here. resolves #15018 Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
* | | Merge pull request #15782 from cevich/bundle_build_tasksOpenShift Merge Robot2022-09-29
|\ \ \ | | | | | | | | Cirrus: Task consolidation
| * | | Cirrus: Combine build and code consistency tasksChris Evich2022-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's conceivable for CI to spend a lot of time testing code which otherwise should be rejected due to quality problems. Previously this was validated in a dedicated task, however a failure would still fail the CI run. Simplify the number of CI tasks by combining the consistency check at the tail-end of the build task. Signed-off-by: Chris Evich <cevich@redhat.com>
| * | | Cirrus: Combine pre-test checks into build taskChris Evich2022-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, two tasks always ran first, prior to anything else. One to verify network and external-service connectivity. Another to verify certain important `.cirrus.yml` standards are met. However, as the total number of tasks continues to grow, the need to keep these basic checks as dedicated prerequisites is of decreasing value/importance. Fold these two checks into a new `pretesting_script` component of the Fedora `build` task, on both `x86_64` and `aarch64`. Signed-off-by: Chris Evich <cevich@redhat.com>
| * | | Cirrus: Minor YAML comment/whitespace fixChris Evich2022-09-29
| | | | | | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | Merge pull request #15998 from Luap99/play-kube-hostnetOpenShift Merge Robot2022-09-29
|\ \ \ \ | |/ / / |/| | | podman kube play allow --network host
| * | | Man pages: refactor common options: --networkEd Santiago2022-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tricky one. In particular: podman-kube-play did not enumerate the "host" option; here I take the liberty of using it in the common network.md, so it will appear in podman-kube-play.1. If that is wrong, please tell me ASAP: I will need to un-refactor podman-kube-play. Other decisions: * move the "invalid if" text to the bottom, because it can't be shared between pod and container man pages. * ditto for "together with --pod" * kube-play said "Change the network mode of"; all the others said ">SET< the network mode >FOR< ...". I chose the latter, so that's what kube-play will have also. Again, if that's wrong, please lmk. Signed-off-by: Ed Santiago <santiago@redhat.com>
| * | | podman kube play allow --network hostPaul Holzinger2022-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I see no reason to block --network host with kube play and force users to have to set it in the yaml file. This is just confusing when compared to the other podman create/run --network options, see discussion in #15945. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | Merge pull request #15994 from Luap99/flake-15990OpenShift Merge Robot2022-09-29
|\ \ \ \ | | | | | | | | | | fix "podman system prune networks" flake
| * | | | fix "podman system prune networks" flakePaul Holzinger2022-09-29
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since by default the network config dir is shared in the e2e tests any other parallel running test could remove a network and cause this test to fail. Fixes #15990 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | Merge pull request #15987 from flouthoc/bump-commonOpenShift Merge Robot2022-09-29
|\ \ \ \ | | | | | | | | | | vendor: bump c/common to `v0.49.2-0.20220929111928-2d1b45ae2423`
| * | | | vendor: bump c/common to v0.49.2-0.20220929111928-2d1b45ae2423Aditya R2022-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Signed-off-by: Aditya R <arajan@redhat.com>
* | | | | Merge pull request #15996 from edsantiago/docs_dedup_log-optOpenShift Merge Robot2022-09-29
|\ \ \ \ \ | |_|_|/ / |/| | | | [CI:DOCS] Man pages: refactor common options: --log-opt
| * | | | Man pages: refactor common options: --log-optEd Santiago2022-09-29
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Simple in reality, but hard to review due to lots of little diffs: - "Logging driver specific options" was only in podman-run; I added it to create and kube-play. - whitespace changes, the 'e.g.'s got consistent 4-space indentation - the "same keys" and "supported only" sentences, I moved up to be closer to **tag** and without intervening whitespace, because they were unclear as they were: I believe the intent is to apply those sentences only to **tag**, not to the **--log-opt** option itself. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | Merge pull request #15992 from Luap99/revert-15988OpenShift Merge Robot2022-09-29
|\ \ \ \ | |/ / / |/| | | Revert "remote: fix manifest add --annotation"
| * | | Revert "remote: fix manifest add --annotation"Paul Holzinger2022-09-29
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 32f54a81ed797597827123b671b6e73194354327. `pkg/bindings` is supported outside of podman and we have to keep it stable. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #15988 from sstosh/manifest-annotate-remoteOpenShift Merge Robot2022-09-29
|\ \ \ | | | | | | | | remote: fix manifest add --annotation
| * | | remote: fix manifest add --annotationToshiki Sonoda2022-09-29
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * `manifest add --annotation option` adds annotations field on remote environment. * `manifest inspect` prints annotations field on remote environment. Fixes: #15952 Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
* | | Merge pull request #15981 from edsantiago/dont_storageoptOpenShift Merge Robot2022-09-29
|\ \ \ | | | | | | | | System tests: stop deep-checking log-level
| * | | System tests: stop deep-checking log-levelEd Santiago2022-09-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I was testing --log-level by --storage-opt=mount_program=/bin/false Stop doing that. It's just constantly breaking everything (#15698 and #15977). I am violently of the opinion that a command-line option must not destroy a user's system (except for --set-something, --config, something that makes it very very clear that it is a lasting change). I seem to be in the minority on this opinion. So, I give up. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | Merge pull request #15971 from ↵OpenShift Merge Robot2022-09-29
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/container-orchestrated-devices/container-device-interface-0.5.2 build(deps): bump github.com/container-orchestrated-devices/container-device-interface from 0.5.1 to 0.5.2
| * | | | build(deps): bump ↵dependabot[bot]2022-09-28
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | github.com/container-orchestrated-devices/container-device-interface Bumps [github.com/container-orchestrated-devices/container-device-interface](https://github.com/container-orchestrated-devices/container-device-interface) from 0.5.1 to 0.5.2. - [Release notes](https://github.com/container-orchestrated-devices/container-device-interface/releases) - [Commits](https://github.com/container-orchestrated-devices/container-device-interface/compare/v0.5.1...v0.5.2) --- updated-dependencies: - dependency-name: github.com/container-orchestrated-devices/container-device-interface dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | | | Merge pull request #15962 from dfr/freebsd-volumeOpenShift Merge Robot2022-09-29
|\ \ \ \ | |_|/ / |/| | | Add volume support for FreeBSD
| * | | libpod: Add volume support for FreeBSDDoug Rabson2022-09-27
| | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <dfr@rabson.org>
| * | | libpod: Factor out usage of unix.MNT_DETACH from (*Volume).unmountDoug Rabson2022-09-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is an existing wrapper for unix.Unmount(..., MNT_DETACH) in util_linux.go but that filters all errors and for volumes, we only want to filter EINVAL. The existing libpod.Unmount seems to only have one call site so perhaps these can be merged. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <dfr@rabson.org>
| * | | libpod: Move volume_internal_linux.go to volume_internal_common.goDoug Rabson2022-09-27
| | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <dfr@rabson.org>
| * | | libpod: Move runtime_volume_linux.go to runtime_volume_common.goDoug Rabson2022-09-27
| | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <dfr@rabson.org>
* | | | Merge pull request #15917 from cevich/check_new_go_codeOpenShift Merge Robot2022-09-29
|\ \ \ \ | | | | | | | | | | [CI:BUILD] Check new go code
| * | | | Cirrus: Add golang code consistency check scriptChris Evich2022-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Depends on #15893 Fixes: #15913 Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | Merge pull request #15968 from piotr-sk/fix/kube_play_liveness_probe_pathOpenShift Merge Robot2022-09-28
|\ \ \ \ \ | |_|_|/ / |/| | | | fix: kube play liveness probe http path
| * | | | fix: kube play liveness probe http pathPiotr2022-09-28
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | Use the default / for http probe path. Update to URI schemes ensuring lowercase Signed-off-by: Piotr <piotr.skoczylas@gmail.com>
* | | | Merge pull request #15946 from rhatdan/kubeOpenShift Merge Robot2022-09-27
|\ \ \ \ | | | | | | | | | | Default missing hostPort to containerPort is defined in kube.yaml
| * | | | Default missing hostPort to containerPort is defined in kube.yamlDaniel J Walsh2022-09-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If user does not specify hostPort in a kube.yml file but does specify a containerPort, then the hostPort should default to the containerPort. Fixes: https://github.com/containers/podman/issues/15942 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #15937 from rhatdan/manOpenShift Merge Robot2022-09-27
|\ \ \ \ \ | | | | | | | | | | | | [CI:DOCS] Add SELinux information about boolean for using random devices
| * | | | | Add SELinux information about boolean for using random devicesDaniel J Walsh2022-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: https://github.com/containers/podman/issues/15930 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #15908 from edsantiago/systemd_tty_testOpenShift Merge Robot2022-09-27
|\ \ \ \ \ \ | | | | | | | | | | | | | | System tests: light cleanup
| * | | | | | System tests: light cleanupEd Santiago2022-09-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Followup to #15895: - add a normal-case test, to ensure that --privileged without systemd continues to pass through /dev/ttyN devices - explain why we die() if host has no ttyN devices - I find grep -vx slightly easier to read than sed backslash-slash - run cleanup with '-t 0', to shave ten seconds from CI run Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | | Merge pull request #15958 from piotr-sk/fix/kube_play_liveness_probeOpenShift Merge Robot2022-09-27
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | fix: liveness check with http probe
| * | | | | | fix: liveness check with http probePiotr2022-09-27
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ensure kubernetes default parameters are respected. Additional curl parameter enforces returning error for HTTP error codes. Use build-in HealthCheckOnFailureAction instead of killing the container while executing the probe. Signed-off-by: Piotr <piotr.skoczylas@gmail.com>
* | | | | | Merge pull request #15896 from edsantiago/dont_install_toolsChris Evich2022-09-27
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | CI: only make install.tools when needed
| * | | | | CI: only make install.tools when neededEd Santiago2022-09-27
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reintroduce .install.foo targets into Makefile, and invoke only the bare-minimum ones needed for each individual CI step in setup_environment.sh. Also add a retry to the golangci-lint curl, in hopes of dealing with network flakes. And remove the -f (fail) because it produces unhelpful logs. Reason: saw about 25% CI flakes yesterday due to the golangci-lint fetch, something about a timeout, and this was especially frustrating because none of the steps actually needed lint. Quick reminder: avoid network fetches unless absolutely necessary. Fixes: #15892 Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | Merge pull request #15948 from ashley-cui/osxcrossOpenShift Merge Robot2022-09-27
|\ \ \ \ \ | |/ / / / |/| | | | Cirrus: Build pkginstaller in CI
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2025-01-30 05:13:03 +0000